On Thu, Apr 16, 2015 at 5:40 PM, Asif Naeem wrote: > Along with fixing the space in installation path, it is also changing the > behavior of install script, why not just "if NOT [%1]==[] GOTO RUN_INSTALL", > checking for "/?" seems good for help message but it seem not well handled > in the script, it is still saying "Invalid command line options.", along > with this, option "/?" seems not handled by any other .bat build script. > Other than this, with the patch applied, is it an acceptable behavior that > (2) shows usage message as 'Usage: install.pl <targetdir> [installtype]' but > (3) shows usage message as 'Usage: "install.bat <path>"'. Thanks.
Thanks for your review! OK, let's remove the use of /? then, consistency with the other scripts is a good argument for its removal.Attached is an updated patch that does the following regarding missing arguments: >install Invalid command line options. Usage: "install.bat <targetdir> [installtype]" installtype: client >install Installing version 9.5 for release in /? Copying build output files...Could not copy release\postgres\postgres.exe to /?\ bin\postgres.exe at Install.pm line 40. Install::lcopy("release\\postgres\\postgres.exe", "/?\\bin\\postgres.exe ") called at Install.pm line 324 Install::CopySolutionOutput("release", "/?") called at Install.pm line 9 3 Install::Install("/?", undef) called at install.pl line 13 This patch fixes of course the issue with spaces included in the target path. I updated as well the Usage in install.bat to be consistent with install.pl. Regards, -- Michael
diff --git a/src/tools/msvc/install.bat b/src/tools/msvc/install.bat index bed08f1..cddb453 100644 --- a/src/tools/msvc/install.bat +++ b/src/tools/msvc/install.bat @@ -1,10 +1,11 @@ @echo off REM src/tools/msvc/install.bat -if NOT "%1"=="" GOTO RUN_INSTALL +if NOT [%1]==[] GOTO RUN_INSTALL echo Invalid command line options. -echo Usage: "install.bat <path>" +echo Usage: "install.bat <targetdir> [installtype]" +echo installtype: client echo. REM exit fix for pre-2003 shell especially if used on buildfarm if "%XP_EXIT_FIX%" == "yes" exit 1 @@ -20,7 +22,7 @@ CALL bldenv.bat del bldenv.bat :nobuildenv -perl install.pl "%1" %2 +perl install.pl %1 %2 REM exit fix for pre-2003 shell especially if used on buildfarm if "%XP_EXIT_FIX%" == "yes" exit %ERRORLEVEL%
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers