On 22/02/15 01:59, Petr Jelinek wrote:
On 21/02/15 22:09, Andrew Dunstan wrote:

On 02/16/2015 09:05 PM, Petr Jelinek wrote:

I found one more issue with the 1.2--1.3 upgrade script, the DROP
FUNCTION pg_stat_statements(); should be DROP FUNCTION
pg_stat_statements(bool); since in 1.2 the function identity has

I think all the outstanding issues are fixed in this patch.

I think PGSS_FILE_HEADER should be also updated, otherwise it's good.

I see you marked this as 'needs review', I am marking it as 'ready for committer' as it looks good to me.

Just don't forget to update the PGSS_FILE_HEADER while committing (I think that one can be threated same way as catversion, ie be updated by committer and not in patch submission).

 Petr Jelinek                  http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:

Reply via email to