On 22.3.2015 16:58, Fabien COELHO wrote: > > About the feature: I find it is a good thing. It may help scripting over > the logs, for instance to compute delays between events, whereas the > full date-time-tz syntax is maybe nice but heavier to work with afterwards. > > In addition to the comments already made (typo in doc, padding...): > > + sprintf(timestamp_str, "%ld.%.03d", > + tv.tv_sec, (int)(tv.tv_usec / 1000)); > > I'm not sure that the "." in "%.03d" is useful. ISTM that it is used for > floatting point formatting, but is not needed with integers.
It is needed for integers, because you need to make sure 1 millisecond is formatted as .001 and not .1. -- Tomas Vondra http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
