On Wed, Apr 1, 2015 at 4:09 AM, Tom Lane <[email protected]> wrote: > Michael Paquier <[email protected]> writes: > > On Tue, Mar 31, 2015 at 9:40 AM, Peter Eisentraut <[email protected]> > wrote: > >> I'm interested in the exact syntax you'd use, to compare it to the > >> currently used techniques. > > > With the presence of VERSION_NUM directly in pg_config, the following > > expression: > > VERSION_NUM=$(shell $(PG_CONFIG) --version-num) > > > With its presence in Makefile.global, that's close to what you can do > with > > pg_config.h already: > > VERSION_NUM := $(shell cat `$(PG_CONFIG) > --libdir`/pgxs/src/Makefile.global > > \ > > | perl -ne 'print $$1 and exit if /VERSION_NUM =\s+(\d+)/') > > But that looks a little bit magic.. > > I'm confused. If PG_VERSION_NUM is defined in Makefile.global, surely > you don't need anything at all to make use of it in extension makefiles. >
No, you don't... But well, coming back to the first point: fetching it through pg_config avoids any ugly parsing logic. -- Michael
