On Fri, Jun 26, 2015 at 2:25 PM, Peter Geoghegan <p...@heroku.com> wrote:
> On Fri, Jun 26, 2015 at 9:29 AM, Robert Haas <robertmh...@gmail.com> wrote:
>> Can you put your suggestions here in the form of a patch to the release 
>> notes?
>
> The attached patch generalizes from the 9.2 release note wording. I
> use the word "inlined" here too, even though commit 5ea86e6e6 did not
> do too much with inlining of C code (unlike the 9.2 stuff that went in
> a little after SortSupport itself).
>
> Seems better to be consistent with the earlier item, and it is still
> probably in some sense true, because the new SortSupport-wise inlined
> comparator probably benefits from inlining more than the historic
> scanKey-wise inlined comparator, due to the removal of indirection.

OK, but how about this wording instead?

diff --git a/doc/src/sgml/release-9.5.sgml b/doc/src/sgml/release-9.5.sgml
index 4086c6b..5e8cc15 100644
--- a/doc/src/sgml/release-9.5.sgml
+++ b/doc/src/sgml/release-9.5.sgml
@@ -221,6 +221,15 @@

       <listitem>
        <para>
+        Extend the infrastructure allow sorting to be performed by inlined,
+        non-<acronym>SQL</acronym>-callable comparison functions to cover
+        <command>CREATE INDEX</>, <command>REINDEX</>, and
+        <command>CLUSTER</> (Peter Geoghegan)
+       </para>
+      </listitem>
+
+      <listitem>
+       <para>
         Improve in-memory hash performance (Tomas Vondra, Robert Haas)
        </para>
       </listitem>

BTW, shouldn't Andrew also be credited here, since he did the work on
datum sorts?

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to