On Fri, Jun 26, 2015 at 10:54 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Well, if you find this to be good code cleanup on its own merits, > you have a commit bit, you can go commit it. I'm just saying that > Coverity is not a good judge of code readability and even less of > a judge of likely future changes. So we should not let it determine > whether we approve of "unnecessary" tests.
Yes, it might not be right in every case, but this one seems like a good change to me, so committed. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
