On Wed, Jul 1, 2015 at 2:52 PM, Amit Kapila <amit.kapil...@gmail.com> wrote:
> On Wed, Jul 1, 2015 at 9:09 AM, Fujii Masao <masao.fu...@gmail.com> wrote:
>>
>> Also regarding pg_xlogdump, we can just document, for example,
>> "please get rid of .paritial suffix from the WAL file name if
>> you want to dump it by pg_xlogdump".
>>
>
> Can't we skip such files in pg_xlogdump?

.partial files are at the end of a timeline, so they will be ignored
now (and this even if a node on the old timeline archives the same
segment as the .partial one sent by the promoted standby). And as
pg_xlogdump is not able to follow a timeline jump there is nothing we
would need to do:
$ pg_xlogdump 000000010000000000000006 000000020000000000000008
pg_xlogdump: FATAL:  could not find file "000000020000000000000006":
No such file or directory
$ pg_xlogdump -t 1 000000010000000000000006 000000020000000000000008
pg_xlogdump: FATAL:  could not find file "000000020000000000000006":
No such file or directory
I am not convinced that it is worth to make pg_xlogdump follow
timeline jumps as well.. One could just run it twice on the old and
new timeline segments to get the output he wants.
-- 
Michael


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to