Fabrízio de Royes Mello wrote: > In this patch I didn't change all lockmode comparison places previous > pointed by you, but I can change it maybe adding other method called > LockModeIsValid(lockmode) to do the comparison "lockmode >= NoLock && > lockmode < MAX_LOCKMODES" used in many places.
I don't like this. Is it possible to write these comparisons in terms of what they conflict with? I think there are two main cases in the existing code: 1. "is this lock mode valid" (sounds reasonable) 2. "can this be acquired in hot standby" (not so much, but makes sense.) and now we have your third thing, "what is the strongest of these two locks". For instance, if you told me to choose between ShareLock and ShareUpdateExclusiveLock I wouldn't know which one is strongest. I don't it's sensible to have the "lock mode compare" primitive honestly. I don't have any great ideas to offer ATM sadly. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
