On Tue, Aug 4, 2015 at 1:18 PM, Andres Freund <and...@anarazel.de> wrote: > On 2015-08-04 13:16:52 -0400, Robert Haas wrote: >> On Mon, Aug 3, 2015 at 10:31 AM, Fujii Masao <masao.fu...@gmail.com> wrote: >> > track_commit_timestamp tracks COMMIT PREPARED as expected in standby >> > server, >> > but not in master server. Is this intentional? It should track COMMIT >> > PREPARED >> > even in master? Otherwise, we cannot use commit_timestamp feature to check >> > the replication lag properly while we use 2PC. >> >> That sounds like it must be a bug. I think you should add it to the >> open items list. > > Yea, completely agreed. It's probably because twophase.c duplicates a > good bit of xact.c. How about we also add a warning to the respective > places that one should always check the others?
Sounds like a good idea. Or we could try to, heh heh, refactor away the duplication. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
