> Hello KaiGai-san, > > I've discovered a bug in the proposed patch - when resetting the hash > table after the first batch, it does this: > > memset(hashtable->buckets, 0, sizeof(nbuckets * sizeof(HashJoinTuple))); > > The first 'sizeof' is bogus, so this only zeroes the first 8 bytes of > the array (usually resulting in crashes due to invalid pointers). > > I fixed it to > > memset(hashtable->buckets, 0, nbuckets * sizeof(HashJoinTuple)); > > Fixed patch attached (marked as v2). > Thanks, it was my bug, but oversight.
I want committer to push this fix. -- NEC Business Creation Division / PG-Strom Project KaiGai Kohei <kai...@ak.jp.nec.com> -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
