* Tom Lane (t...@sss.pgh.pa.us) wrote: > Alvaro Herrera <alvhe...@2ndquadrant.com> writes: > > I noticed that COPY calls planner() (this was introduced in 85188ab88). > > I think it should be calling pg_plan_query() instead. > > +1 --- AFAICS, this is the *only* place that is going directly to > planner() without going through pg_plan_query(); other utility > functions such as CREATE TABLE AS do the latter. > > As far as the patch goes, do copy.c's #include's need adjustment? > I'm wondering if optimizer/planner.h could be removed, in particular.
BeginCopyFrom still uses expression_planner(), at least.. Thanks! Stephen
Description: Digital signature