Stephen Frost wrote: > * Tom Lane (t...@sss.pgh.pa.us) wrote: > > Alvaro Herrera <alvhe...@2ndquadrant.com> writes: > > > I noticed that COPY calls planner() (this was introduced in 85188ab88). > > > I think it should be calling pg_plan_query() instead. > > > > +1 --- AFAICS, this is the *only* place that is going directly to > > planner() without going through pg_plan_query(); other utility > > functions such as CREATE TABLE AS do the latter.
Yeah, exactly. Thus, pushed. > > As far as the patch goes, do copy.c's #include's need adjustment? > > I'm wondering if optimizer/planner.h could be removed, in particular. > > BeginCopyFrom still uses expression_planner(), at least.. Yup. However I notice that there are a few other callers of expression_planner() that do not involve the optimizer for anything else. Maybe it makes sense to have a separate header file that's just #include "nodes/primnodes.h" extern Expr *expression_planner(Expr *expr); extern bool plan_cluster_use_sort(Oid tableOid, Oid indexOid); Seems it could be used by a large percentage of files currently including planner.h. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
