On Tue, Sep 22, 2015 at 3:16 PM, Jim Nasby <jim.na...@bluetreble.com> wrote: > At first I thought the lack of context indicated a palloc had failed during > ereport() (since we apparently just toss the previous error when that > happens), but it turns out there's some error reporting in > pg_stat_statements that's less than ideal. Attached patch fixes, though I'm > not sure if %lld is portable or not.
+ ereport(LOG, + (errcode(ERRCODE_OUT_OF_MEMORY), + errmsg("out of memory attempting to pg_stat_statement file"), + errdetail("file \"%s\": size %lld", PGSS_TEXT_FILE, stat.st_size))); Uh, what? I'm not opposed to this basic idea, but I think the message should be reworded, and that the presence of two separate ereport() call sites like the above is totally unnecessary. The existing MaxAllocSize check is just defensive; no user-visible distinction needs to be made. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers