On 2015/11/25 11:31, Robert Haas wrote: > On Tue, Nov 24, 2015 at 1:06 AM, Amit Langote > <langote_amit...@lab.ntt.co.jp> wrote: >> While going through nodeGather.c, I noticed portions of the file header >> comment that may have been obsoleted by recent revisions of the relevant >> parellelism code. For example, there is a reference to PartialSeqScan node >> which did not make it into the tree. Attached fixes it. Also, wondering if >> the semantics of Gather node is that of Scan or more generic Plan? That is >> to ask whether the following edit makes sense: >> >> * nodeGather.c >> - * Support routines for scanning a plan via multiple workers. >> + * Support routines for getting the result from a plan via multiple >> + * workers. >> * > > Well I think "scanning a plan" is clear enough even if it's > technically a Scan.
Okay, ripped that out in the attached. Thanks, Amit
diff --git a/src/backend/executor/nodeGather.c b/src/backend/executor/nodeGather.c index b6e82d1..10e2319 100644 --- a/src/backend/executor/nodeGather.c +++ b/src/backend/executor/nodeGather.c @@ -11,7 +11,8 @@ * or have not started up yet. It then merges all of the results it produces * and the results from the workers into a single output stream. Therefore, * it will normally be used with a plan where running multiple copies of the - * same plan does not produce duplicate output, such as PartialSeqScan. + * same plan does not produce duplicate output, such as parallel-aware + * SeqScan. * * Alternatively, a Gather node can be configured to use just one worker * and the single-copy flag can be set. In this case, the Gather node will
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
