Hello, I've noticed that in src/backend/replication/logical/reorderbuffer.c, the IDENTIFICATION comment line is incorrect:
* IDENTIFICATION * src/backend/replication/reorderbuffer.c By using a simple find+grep command I can see this is also the case for the following files: $ find src -name \*.c -o -name \*.h | xargs grep -A1 IDENTIFICATION | grep -v -E 'IDENTIFICATION|--' | grep -v '^\(src/.*\.[ch]\)-\s*\*\s*\1\s*$' src/include/utils/evtcache.h- * src/backend/utils/cache/evtcache.c src/backend/utils/cache/relfilenodemap.c- * src/backend/utils/cache/relfilenode.c src/backend/utils/adt/version.c- * src/backend/storage/ipc/dsm_impl.c- * src/backend/storage/ipc/dsm.c src/backend/replication/logical/reorderbuffer.c- * src/backend/replication/reorderbuffer.c src/backend/replication/logical/snapbuild.c- * src/backend/replication/snapbuild.c src/backend/replication/logical/logicalfuncs.c- * src/backend/replication/logicalfuncs.c src/backend/commands/dropcmds.c- * src/backend/catalog/dropcmds.c The one wtih version.c is a false positive: there's just an extra blank line in the comment. A patch to fix the the above is attached. Another minor thing is that if there is a convention for the order of Copyright, NOTES and IDENTIFICATION, then it is not followed strictly. Compare e.g. reorderbuffer.c vs. snapbuild.c. -- Alex
From 4e71c026be7d1a75710fe89177d0dd37d8d84421 Mon Sep 17 00:00:00 2001 From: Oleksandr Shulgin <oleksandr.shul...@zalando.de> Date: Mon, 18 Jan 2016 12:49:32 +0100 Subject: [PATCH] Assorted IDENTIFICATION comment line fixes. --- src/backend/commands/dropcmds.c | 2 +- src/backend/replication/logical/logicalfuncs.c | 2 +- src/backend/replication/logical/reorderbuffer.c | 2 +- src/backend/replication/logical/snapbuild.c | 2 +- src/backend/storage/ipc/dsm_impl.c | 2 +- src/backend/utils/cache/relfilenodemap.c | 2 +- src/include/utils/evtcache.h | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/backend/commands/dropcmds.c b/src/backend/commands/dropcmds.c index 522027a..20b42fe 100644 --- a/src/backend/commands/dropcmds.c +++ b/src/backend/commands/dropcmds.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * src/backend/catalog/dropcmds.c + * src/backend/commands/dropcmds.c * *------------------------------------------------------------------------- */ diff --git a/src/backend/replication/logical/logicalfuncs.c b/src/backend/replication/logical/logicalfuncs.c index 56e47e4..562c8f6 100644 --- a/src/backend/replication/logical/logicalfuncs.c +++ b/src/backend/replication/logical/logicalfuncs.c @@ -9,7 +9,7 @@ * Copyright (c) 2012-2016, PostgreSQL Global Development Group * * IDENTIFICATION - * src/backend/replication/logicalfuncs.c + * src/backend/replication/logical/logicalfuncs.c *------------------------------------------------------------------------- */ diff --git a/src/backend/replication/logical/reorderbuffer.c b/src/backend/replication/logical/reorderbuffer.c index 78acced..7402f20 100644 --- a/src/backend/replication/logical/reorderbuffer.c +++ b/src/backend/replication/logical/reorderbuffer.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * src/backend/replication/reorderbuffer.c + * src/backend/replication/logical/reorderbuffer.c * * NOTES * This module gets handed individual pieces of transactions in the order diff --git a/src/backend/replication/logical/snapbuild.c b/src/backend/replication/logical/snapbuild.c index 97c1ad4..1dd302b 100644 --- a/src/backend/replication/logical/snapbuild.c +++ b/src/backend/replication/logical/snapbuild.c @@ -99,7 +99,7 @@ * Copyright (c) 2012-2016, PostgreSQL Global Development Group * * IDENTIFICATION - * src/backend/replication/snapbuild.c + * src/backend/replication/logical/snapbuild.c * *------------------------------------------------------------------------- */ diff --git a/src/backend/storage/ipc/dsm_impl.c b/src/backend/storage/ipc/dsm_impl.c index 5d7b46f..297cfdd 100644 --- a/src/backend/storage/ipc/dsm_impl.c +++ b/src/backend/storage/ipc/dsm_impl.c @@ -41,7 +41,7 @@ * * * IDENTIFICATION - * src/backend/storage/ipc/dsm.c + * src/backend/storage/ipc/dsm_impl.c * *------------------------------------------------------------------------- */ diff --git a/src/backend/utils/cache/relfilenodemap.c b/src/backend/utils/cache/relfilenodemap.c index 894dacb..bef4d5b 100644 --- a/src/backend/utils/cache/relfilenodemap.c +++ b/src/backend/utils/cache/relfilenodemap.c @@ -7,7 +7,7 @@ * Portions Copyright (c) 1994, Regents of the University of California * * IDENTIFICATION - * src/backend/utils/cache/relfilenode.c + * src/backend/utils/cache/relfilenodemap.c * *------------------------------------------------------------------------- */ diff --git a/src/include/utils/evtcache.h b/src/include/utils/evtcache.h index 7c8da74..76d2519 100644 --- a/src/include/utils/evtcache.h +++ b/src/include/utils/evtcache.h @@ -7,7 +7,7 @@ * Portions Copyright (c) 1994, Regents of the University of California * * IDENTIFICATION - * src/backend/utils/cache/evtcache.c + * src/include/utils/evtcache.h * *------------------------------------------------------------------------- */ -- 2.5.0
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
