Masahiko Sawada wrote: > I misunderstood. Sorry for noise. > I agree with adding conversion method as a pageConverter routine.
\o/ > This patch doesn't change page layout actually, but pageConverter > routine checks only the page layout. > And we have to plugin named convertLayout_X_to_Y. > > I think we have two options. > > 1. Change page layout(PG_PAGE_LAYOUT_VERSION) to 5. pg_upgrade detects > it and then converts only VM files. > 2. Change pg_upgrade plugin mechanism so that it can handle other name > conversion plugins (e.g., convertLayout_vm_to_vfm) > > I think #2 is better. Thought? My vote is for #2 as well. Maybe we just didn't have forks when this functionality was invented; maybe the author just didn't think hard enough about what would be the right interface to do it. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
