On 2016-02-04 22:24:50 +0900, Fujii Masao wrote: > But, IIRC, one of the problems that prevent the adoption of this feature is > the addition of gettimeofday() call after every SQL command receipt. > Have you already resolved that problem? Or we don't need to care about > it because it's almost harmless?
Well, it only happens when the feature is enabled, not unconditionally. So I don't think that's particularly bad, as long as the feature is not enabled by default. If we feel we need to something about the gettimeofday() call at some point, I think it'd made a lot of sense to introduce a more centralize "statement stop" time, and an extended pgstat_report_activity() that allows to specify the timestamp. Because right now we'll essentially do gettimeofday() calls successively when starting a command, starting a transaction, committing a transaction, and finishing a comment. That's pretty pointless. Andres -- Sent via pgsql-hackers mailing list (email@example.com) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers