Hello, Andres

You have introduced a large replication progress tracking infrastructure last year. And there is a problem described at the link in the quote below.


Attached patch fix this issue. Is this patch correct? I will be grateful if it is and if it will be committed.

Thanks.

On 29.02.2016 14:18, Artur Zakirov wrote:
Hello,

I read this message
http://www.postgresql.org/message-id/56d4197e.9050...@informatik.uni-kl.de

Is this a bug or a typo? In DecodeCommit() in decode.c instead of:

if (parsed->xinfo & XACT_XINFO_HAS_ORIGIN)
{
     origin_lsn = parsed->origin_lsn;
     commit_time = parsed->origin_timestamp;
}

should be:

if (parsed->xinfo & XACT_XINFO_HAS_ORIGIN)
{
     origin_lsn = parsed->origin_lsn;
     commit_time = parsed->origin_timestamp;
}
else
     commit_time = parsed->xact_time;



--
Artur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
*** a/src/backend/replication/logical/decode.c
--- b/src/backend/replication/logical/decode.c
***************
*** 458,463 **** DecodeCommit(LogicalDecodingContext *ctx, XLogRecordBuffer *buf,
--- 458,465 ----
  		origin_lsn = parsed->origin_lsn;
  		commit_time = parsed->origin_timestamp;
  	}
+ 	else
+ 		commit_time = parsed->xact_time;
  
  	/*
  	 * Process invalidation messages, even if we're not interested in the
-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to