> On 11 Mar 2016, at 19:41, Jesper Pedersen <jesper.peder...@redhat.com> wrote:

Thanks for review, Jesper.

> Some comments:
> * The patch needs a rebase against the latest TwoPhaseFileHeader change


> * Rework the check.sh script into a TAP test case (src/test/recovery), as 
> suggested by Alvaro and Michael down thread

Done. Originally I thought about reducing number of tests (11 right now), but 
now, after some debugging, I’m more convinced that it is better to include them 
all, as they are really testing different code paths.

> * Add documentation for RecoverPreparedFromXLOG


Stas Kelvich
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company

Attachment: twophase_replay.v2.diff
Description: Binary data

Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:

Reply via email to