On 2016-03-18 20:14:07 +0530, Amit Kapila wrote: > + * from inside a signal handler in latch_sigusr1_handler(). > > * > > * Note: we assume that the kernel calls involved in drainSelfPipe() > > * and SetLatch() will provide adequate synchronization on machines > > * with weak memory ordering, so that we cannot miss seeing is_set if > > * the signal byte is already in the pipe when we drain it. > > */ > > - drainSelfPipe(); > > - > > > Above part of comment looks redundant after this patch.
Don't think so. Moving it closer to the drainSelfPipe() call might be neat, but since there's several callsites... > I have done some > tests on Windows with 0003 patch which includes running the regressions > (vcregress check) and it passes. Will look into it tomorrow once again and > share if I find anything wrong with it, but feel to proceed if you want. Thanks for the testing thus far! Let's see what the buildfarm has to say. Andres -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
