On Sun, Mar 20, 2016 at 11:24 PM, Alvaro Herrera <alvhe...@2ndquadrant.com> wrote: > David Rowley wrote: >> On 21 March 2016 at 15:48, Alvaro Herrera <alvhe...@2ndquadrant.com> wrote: >> > David Rowley wrote: >> > >> >> I've rewritten the comment to become: >> >> >> >> /* >> >> * Providing that the estimated size of the hashtable does not exceed >> >> * work_mem, we'll generate a HashAgg Path, although if we were unable >> >> * to sort above, then we'd better generate a Path, so that we at least >> >> * have one. >> >> */ >> >> >> >> How about that? >> > >> > I think "Providing" should be "Provided". >> >> Both make sense, although I do only see instances of "Provided that" >> in the source. > > Interesting. "Providing that" seems awkward to me, and I had only seen > the other wording thus far, but > http://english.stackexchange.com/questions/149459/what-is-the-difference-between-providing-that-and-provided-that > explains that I'm wrong.
Well, my instincts are the same as yours, actually... -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers