On Sat, Apr 9, 2016 at 12:32 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Jeff Janes <jeff.ja...@gmail.com> writes: >> When I compile now without cassert, I get the compiler warning: > >> syncrep.c: In function 'SyncRepUpdateConfig': >> syncrep.c:878:6: warning: variable 'parse_rc' set but not used >> [-Wunused-but-set-variable]
Thanks for the report! > If there's a good reason for that to be an Assert, I don't see it. > There are no callers of SyncRepUpdateConfig that look like they > need to, or should expect not to have to, tolerate errors. > I think the way to fix this is to turn the Assert into a plain > old test-and-ereport-ERROR. Okay, I pushed that change. Thanks for the suggestion! Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
