On Tue, Mar 22, 2016 at 12:56 AM, Amit Kapila <amit.kapil...@gmail.com> wrote: >> >> Yes, same random number generation is not the problem. In windows apart >> >> from EEXIST error, EACCES also needs to be validated and returned for >> >> new random number generation, instead of throwing an error. >> > >> > Doing the same handling for EACCES doesn't seem to be sane because if >> > EACCES >> > came for reason other than duplicate dsm name, then we want to report >> > the >> > error instead of trying to regenerate the name. I think here fix should >> > be >> > to append data_dir path as we do for main shared memory. >> >> Yes, EACCES may be possible other than duplicate dsm name. > > So as far as I can see there are two ways to resolve this issue, one is to > retry generation of dsm name if CreateFileMapping returns EACCES and second > is to append data_dir name to dsm name as the same is done for main shared > memory, that will avoid the error to occur. First approach has minor flaw > that if CreateFileMapping returns EACCES due to reason other then duplicate > dsm name which I am not sure is possible to identify, then we should report > error instead try to regenerate the name > > Robert and or others, can you share your opinion on what is the best way to > proceed for this issue.
I think we should retry on EACCES. Possibly we should do other things too, but at least that. It completely misses the point of retrying on EEXIST if we don't retry on other error codes that can also be generated when the segment already exists. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers