On Tue, Jun 21, 2016 at 1:49 PM, Andres Freund <and...@anarazel.de> wrote: >> I'm also a bit dubious that LockAcquire is safe to call in general >> with interrupts held. > > Looks like we could just acquire the tuple-lock *before* doing the > toast_insert_or_update/RelationGetBufferForTuple, but after releasing > the buffer lock. That'd allow us to do avoid doing the nested locking, > should make the recovery just a goto l2;, ...
Why isn't that racey? Somebody else can grab the tuple lock after we release the buffer content lock and before we acquire the tuple lock. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
