On Sat, Jul 30, 2016 at 1:17 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Robert Haas <robertmh...@gmail.com> writes: >> On Tue, Jul 26, 2016 at 9:27 PM, Michael Paquier >> <michael.paqu...@gmail.com> wrote: >>> While looking at the series of functions pg_get_*, I have noticed as >>> well that pg_get_userbyid() returns "unknown (OID=%u)" when it does >>> not know a user. Perhaps we'd want to change that to NULL for >>> consistency with the rest? > >> That's probably correct in theory, but it's a little less closely >> related, and I'm not entirely sure how far we want to go with this. >> Remember, the original purpose was to avoid having an internal error >> (cache lookup failed, XX000) exposed as a user-visible error message. >> Are we at risk from veering from actual bug-fixing off into useless >> tinkering? Not sure. > > I'd vote for leaving that one alone; yeah, it's a bit inconsistent > now, but no one has complained about its behavior.
OK for me. Thanks for the commit. -- Michael -- Sent via pgsql-hackers mailing list (email@example.com) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers