On Sat, Aug 20, 2016 at 7:37 AM, Amit Kapila <amit.kapil...@gmail.com> wrote: > 2. > + if (dsm_control->item[seg->control_slot].pinned) > + elog(ERROR, "cannot pin a segment that is already pinned"); > > Shouldn't this be a user facing error (which means we should use ereport)?
Uh, certainly not. This can't happen because of SQL the user enters; it can only happen because of a C coding error. elog() is the appropriate tool for that case. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (email@example.com) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers