On 23/08/16 02:55, Craig Ringer wrote:
On 23 August 2016 at 01:03, Robert Haas <robertmh...@gmail.com
<mailto:robertmh...@gmail.com>> wrote:

    I think you should use underscores to separate all of the words
    instead of only some of them.

ifassigned => if_assigned

ifrecent=> if_recent

Updated patch series attached. As before, 0-4 intended for commit, 5
just because it'll be handy to have around for people doing wraparound
related testing.

I guess you mean 0-3 for commit and 4 is just handy?

From the point of code this patch seems good to me.

I do wonder about the 3rd patch though. I wonder if it would not be better to have the opposite function instead - converting xid to txid as that will always work and does not have to have the NULL case and would be simpler in terms of code.

  Petr Jelinek                  http://www.2ndQuadrant.com/
  PostgreSQL Development, 24x7 Support, Training & Services

Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:

Reply via email to