On 8/20/16 3:05 PM, Tom Lane wrote: > Make initdb's suggested "pg_ctl start" command line more reliable. > > The original coding here was not nearly careful enough about quoting > special characters, and it didn't get corner cases right for constructing > the pg_ctl path either. Use join_path_components() and appendShellString() > to do it honestly, so that the string will more likely work if blindly > copied-and-pasted. > > While at it, teach appendShellString() not to quote strings that clearly > don't need it, so that the output from initdb doesn't become uglier than > it was before in typical cases where quoting is not needed.
A couple of problems with this: The not-quoting-if-not-needed doesn't appear to do anything useful for me: 'pg-install/bin/pg_ctl' -D 'pg-install/var/data' -l logfile start The indentation of that line was changed from 4 to 10. I don't think that was a good change. As just mentioned elsewhere, this accidentally introduces a failure if the PostgreSQL installation path contains LF/CR, because of the use of appendShellString(). -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers