Robert Haas <robertmh...@gmail.com> writes: > On Thu, May 26, 2016 at 7:44 PM, Michael Paquier > <michael.paqu...@gmail.com> wrote: >> Yeah, it is definitely better to register it. And I have switched the >> patch as ready for committer just now.
> Committed and back-patched to 9.4, where DSM was introduced. ISTM both the previous coding and this version can fail for no good reason, that is what if GetLastError() happens to return one of these error codes as a result of some unrelated failure from before this subroutine is entered? That is, wouldn't it be a good idea to do SetLastError(0) before calling CreateFileMapping? Or is the latter guaranteed to do that on success? I don't see that stated in its man page. regards, tom lane -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers