Amit Kapila <amit.kapil...@gmail.com> writes:
> On Tue, Sep 20, 2016 at 10:33 PM, Tom Lane <t...@sss.pgh.pa.us> wrote:
>> ISTM both the previous coding and this version can fail for no good
>> reason, that is what if GetLastError() happens to return one of these
>> error codes as a result of some unrelated failure from before this
>> subroutine is entered? That is, wouldn't it be a good idea to
>> do SetLastError(0) before calling CreateFileMapping?
> Yes, that seems like a good idea. Do you need a patch with some
> testing on windows environment?
Please; I can't test it.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
