On Fri, Nov 25, 2016 at 4:16 AM, Mithun Cy <mithun...@enterprisedb.com> wrote: > On Fri, Nov 25, 2016 at 12:03 PM, Andreas Karlsson <andr...@proxel.se> > wrote: >> Another thought about this code: should we not check if it is a unix >> socket first before splitting the host? While I doubt that it is common to >> have a unix >socket in a directory with comma in the path it is a bit >> annoying that we no longer support this. > > I think it is a bug. > > Before this feature: > > ./psql postgres://%2fhome%2fmithun%2f%2c > psql: could not connect to server: No such file or directory > Is the server running locally and accepting > connections on Unix domain socket "/home/mithun/,/.s.PGSQL.5444"? > > After this feature: > ./psql postgres://%2fhome%2fmithun%2f%2c > psql: could not connect to server: No such file or directory > Is the server running locally and accepting > connections on Unix domain socket "/home/mithun//.s.PGSQL.5432"? > could not connect to server: Connection refused > Is the server running on host "" (::1) and accepting > TCP/IP connections on port 5432? > could not connect to server: Connection refused > Is the server running on host "" (127.0.0.1) and accepting > TCP/IP connections on port 5432? > > So comma (%2c) is misinterpreted as separator not as part of UDS path. > > Reason is we first decode the URI(percent encoded character) then try to > split the string into multiple host assuming they are separated by ','. I > think we need to change the order here. Otherwise difficult the say whether > ',' is part of USD path or a separator.
Yeah, we should change that. Are you going to write a patch? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
