On Sat, Dec 31, 2016 at 11:17 AM, Peter Eisentraut <peter.eisentr...@2ndquadrant.com> wrote: > On 12/1/16 9:32 PM, Peter Eisentraut wrote: >> I think it would be better to get rid of objargs and have objname be a >> general Node that can contain more specific node types so that there is >> some amount of type tracking. FuncWithArgs would be one such type, >> Typename would be another, Value would be used for simple strings, and >> we could create some other ones, or stick with lcons for some simple >> cases. But then we don't have to make stuff into one-item lists to just >> to satisfy the currently required List. >> >> That's the general idea. But that's a rather big change that I would >> rather break down into smaller pieces. > > People wanted to the whole thing at once, so here it is. > > Patches 0001 and 0002 are some prep work. Patch 0003 is the main patch > that removes the objargs fields and changes the objname to a generic > Node*. 0004 is an API simplification that could be committed together > with 0003 but I kept it separate for easier review. 0005 accomplishes > the DROP FUNCTION changes. 0006 is some other cleanup that fell out of > this.
I haven't reviewed this in any detail but I think the general approach is sensible. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers