Etsuro Fujita <fujita.ets...@lab.ntt.co.jp> writes: > On 2017/01/06 21:25, Ashutosh Bapat wrote: >> On Thu, Jan 5, 2017 at 2:49 PM, Etsuro Fujita >> <fujita.ets...@lab.ntt.co.jp> wrote: >>> On 2017/01/03 15:57, Ashutosh Bapat wrote: >>>> The patch looks good to me, but I feel there are too many testscases.
>>> I don't object to that, but (1) the tests I added wouldn't be that >>> time-consuming, and (2) they would be more expected to help find bugs, in >>> general, so I'd vote for keeping them. How about leaving that for the >>> committer's judge? >> Ok. Marking this as ready for committer. > Thanks! Pushed. I ended up simplifying the tests some, partly because I agreed it seemed like overkill, but mostly because they weren't testing the bug. The prepared statements that had parameters would have been replanned anyway, because plancache.c wouldn't have generated enough plans to decide if a generic plan would be ok. regards, tom lane -- Sent via pgsql-hackers mailing list (email@example.com) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers