On Tue, Dec 27, 2016 at 6:50 PM, Peter Eisentraut <peter.eisentr...@2ndquadrant.com> wrote: > Updated patch attached.
Some more things I noticed following another quick read over the patch: * I think it's worth looking into ucol_nextSortKeyPart(), and using that as an alternative to ucol_getSortKey(). It doesn't seem any harder, and when I tested it it was clearly faster. (I think that ucol_nextSortKeyPart() is more or less intended to be used for abbreviated keys.) * I think that it's not okay that convert_string_datum() still uses strxfrm() without considering if it's an ICU build. That's why I raised the idea of a pg_strxfrm() wrapper at one point. * Similarly, I think that check_strxfrm_bug() should have something about ICU. It's looking for a particular bug in some very old version of Solaris 8. At a minimum, check_strxfrm_bug() should now not run at all (a broken OS strxfrm() shouldn't be a problem with ICU). Otherwise, it could do some kind of testing on our pg_strxfrm() wrapper (or similar). -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (email@example.com) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers