On 1/12/17 12:25 AM, Kuntal Ghosh wrote: > On Wed, Jan 11, 2017 at 9:42 PM, Peter Eisentraut > <peter.eisentr...@2ndquadrant.com> wrote: >> There are approximately 11 copies of atooid() and 3 of oid_cmp() or >> equivalent, and pending patches are proposing to add more. I propose >> these two patches to collect them in central places. >> > I've verified that the patch covers all the copies of atooid() and > oid_cmp() that should be replaced. However, as Tom suggested, I've > looked into pg_dump and found that there is a oidcmp() as well. It may > have been missed because it has a different name. > > I was wondering whether it is worth to replace the following as well: > (TransactionId)strtoul(str, NULL, 16) to something like #define atotranid().
There is a atoxid(), which is actually not used and removed by my patch. There are a few other calls of this pattern, but they are not frequent or consistent enough to worry about (yet), I think. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (email@example.com) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers