On Wed, Jan 18, 2017 at 4:11 PM, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > updated patch attached.
Thanks for the new version. > Added tap tests patch also attached. This begins to look really nice. I am having fun torturing it :) Here are I think my last comments: + linecxt = tokenize_file(HbaFileName, file, &hba_lines, &hba_line_nums, &hba_raw_lines); + FreeFile(file); tokenize_file can leave on ERROR, in which case the file descriptor would leak. You much likely need a PG_END_ENSURE_ERROR_CLEANUP/PG_ENSURE_ERROR_CLEANUP block here with a callback to FreeFile() if an error is caught. + <entry> + ADDRESS specifies the set of hosts the record matches. + It can be a host name, or it is made up of an IP address + or keywords such as (<literal>all</literal>, + <literal>samehost</literal> and <literal>samenet</literal>). + </entry> Why is that upper-case? + <entry> + If not null, an error message indicating why this + rule could not be loaded + </entry> Need a dot here, that's a sentence. src/test/regress/expected/rules.out needs to be refreshed, regression tests are failing. -- Michael -- Sent via pgsql-hackers mailing list (email@example.com) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers