Hi, Please find the attached v4 patch rebased on a latest commitID in head. I had to rebase it as the following git commit has some changes in pgstatindex.c file due to which 'git apply' was failing.
<git-commit> commit f21a563d25dbae153937aec062161184189478b8 Author: Peter Eisentraut <pete...@gmx.net> Date: Fri Jan 20 20:29:53 2017 -0500 Move some things from builtins.h to new header files </git-commit> On Thu, Jan 19, 2017 at 12:27 PM, Ashutosh Sharma <ashu.coe...@gmail.com> wrote: >> However, I've some minor comments on the patch: >> >> +/* >> + * HASH_ALLOCATABLE_PAGE_SZ represents allocatable >> + * space (pd_upper - pd_lower) on a hash page. >> + */ >> +#define HASH_ALLOCATABLE_PAGE_SZ \ >> + BLCKSZ - \ >> + (SizeOfPageHeaderData + sizeof(HashPageOpaqueData)) >> My suggestion will be not to write "(pd_upper - pd_lower)" in the >> comment. You may write allocatable space on a empty hash page. > > Accepted. Have changed the comment accordingly. > >> >> + buf = ReadBufferExtended(rel, MAIN_FORKNUM, blkno, >> RBM_NORMAL, NULL); >> Use BAS_BULKREAD strategy to read the buffer. >> > > okay, corrected. Please check the attached v3 patch with corrections. > > With Regards, > Ashutosh Sharma > EnterpriseDB: http://www.enterprisedb.com
0001-Add-pgstathashindex-to-pgstattuple-extension-v4.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers