On Tue, Jan 24, 2017 at 10:09 AM, Ashutosh Sharma <ashu.coe...@gmail.com> wrote: >> I've looked at the patch. It looks good. However, I was wondering why >> an exclusive lock for extension is necessary for reading the number >> blocks in this case. Please refer to the following code. >> >> + /* Get the current relation length */ >> + LockRelationForExtension(rel, ExclusiveLock); >> + nblocks = RelationGetNumberOfBlocks(rel); >> + UnlockRelationForExtension(rel, ExclusiveLock); >> >> Apart from this, I've nothing else to add. > > > Actually in my case I may not need to acquire ExclusiveLock just to > get the number of pages in a relation. Infact I have already opened a > relation using > 'AccessShareLock' which should be enough to read a table length. > Thanks for putting this point. I have corrected it in the attached v5 > patch. I've checked the last attached patch and didn't find any issue. There is no problem with patching and compilation. It also passed all regression tests. Nothing else to add from my side. I'm marking this 'Ready for commiter'.
-- Thanks & Regards, Kuntal Ghosh EnterpriseDB: http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (email@example.com) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers