On 1/25/17, Haribabu Kommi <kommi.harib...@gmail.com> wrote:
> On Wed, Jan 25, 2017 at 6:43 PM, Vitaly Burovoy <vitaly.buro...@gmail.com>
>> On 1/23/17, Haribabu Kommi <kommi.harib...@gmail.com> wrote:
>> > The patch is split into two parts.
>> > 1. Macaddr8 datatype support
>> > 2. Contrib module support.
>> I'm sorry for the delay.
>> The patch is almost done, but I have two requests since the last review.
> Thanks for the review.
>> + int a,
>> + b,
>> + c,
>> + d = 0,
>> + e = 0,
>> There is no reason to set them as 0. For EUI-48 they will be
>> reassigned in the "if (count != 8)" block, for EUI-64 -- in one of
>> They could be set to "d = 0xFF, e = 0xFE," and avoid the "if" block
>> mentioned above, but it makes the code be much less readable.
> Changed accordingly.
I'm going to do (I hope) a final review tonight.
Please, remove initialization of the variables "d" and "e" since there
is really no reason to keep them be zero for a short time.
Sent via pgsql-hackers mailing list (email@example.com)
To make changes to your subscription: