On Wed, Feb 1, 2017 at 6:27 AM, Vitaly Burovoy <vitaly.buro...@gmail.com> wrote:
> Hello, > > I've reviewed the patch[1]. > > Result of testing: > > make installcheck-world: tested, passed > Implements feature: tested, passed > Spec compliant: tested, passed > Documentation: tested, passed > > > The patch introduce a new type macaddr8 for EUI-64 addresses[2] > (assuming OUI field is 24 bits wide) with EUI-48 (existing "macaddr" > type) interoperability. > It is a mostly copy-pasted macaddr implementation with necessary > changes for increased range. > Consensus was reached on such implementation in the current thread before. > > There are two patch files for convenient reviewing: base macaddr8 > implementation and its supporting in btree-gin and btree-gist indexes. > > The patch: > * cleanly applies to the current master > (6af8b89adba16f97bee0d3b01256861e10d0e4f1); > * passes tests; > * looks fine, follows the PostgreSQL style guide; > * has documentation changes; > * has tests. > > All notes and requirements were took into account and the patch was > changed according to them. > I have no suggestions on improving it. > > The new status of this patch is: Ready for Committer > Thanks for the review. Regards, Hari Babu Fujitsu Australia
