On 2017-01-26 13:16:13 -0500, Robert Haas wrote: > > OK, I have done this refactoring effort as attached because I think > > that's really worth it. And here are the diff numbers: > > 3 files changed, 113 insertions(+), 162 deletions(-) > > That's a bit less than what I thought first because of all the > > singularities of bytea in its output and the way TIMELINE_HISTORY > > takes advantage of the message level routines. Still for > > IDENTIFY_SYSTEM, START_REPLICATION and CREATE_REPLICATION_SLOT the > > gains in readability are here. > > Seems OK to me, but I think I'd want to hear a few other opinions > before committing it.
Just to be absolutely sure: We're talking about Michael's cleanup patch, not the thread's original topic? Andres -- Sent via pgsql-hackers mailing list (email@example.com) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers