Andres Freund wrote: > On 2017-01-31 14:10:01 -0300, Alvaro Herrera wrote:
> > Hmm, I was thinking we would get rid of CatalogUpdateIndexes altogether. > > Two of the callers are in the new routines (which I propose to rename to > > CatalogTupleInsert and CatalogTupleUpdate); the only remaining one is in > > InsertPgAttributeTuple. I propose that we inline the three lines into > > all those places and just remove CatalogUpdateIndexes. Half the out-of- > > core places that are using this function will be broken as soon as WARM > > lands anyway. I see no reason to keep it. (I have already modified the > > patch this way -- no need to resend). > > > > Unless there are objections I will push this later this afternoon. > > Hm, sorry for missing this earlier. I think CatalogUpdateIndexes() is > fairly widely used in extensions - it seems like a pretty harsh change > to not leave some backward compatibility layer in place. Yeah, I can put it back if there's pushback about the removal, but I think it's going to break due to WARM anyway. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
