On Thu, Feb 02, 2017 at 10:34:43AM -0500, Bruce Momjian wrote: > On Thu, Feb 2, 2017 at 07:18:45AM -0800, David Fetter wrote: > > On Thu, Feb 02, 2017 at 03:16:29PM +0000, Bruce Momjian wrote: > > > I just don't see this patch going in. I think it needs are > > > larger approach to the problems it is trying to solve. I think > > > it then will be very useful. > > > > What problems that it's trying to solve are not addressed? > > Unjoined tables. Inconsistent alias references. I think there are > a bunch of things and if we can make a list and get a mode to warn > about all of them, it would be very useful.
There is always a delicate balance between putting in all that's required for a minimum viable feature and actually getting something out there. As I see it, this feature's main benefit is that it prevents some very common and at the same time very damaging kinds of harm. It also, for now, serves a pedagogical purpose. It's relatively straight-forward for someone with little or no PostgreSQL experience to look at it and see what it does. I originally sent the feature to cover unsubtle types of blunders, I'd like to keep "unsubtle blunders" as the guiding principle here. I can see where an unintentional CROSS JOIN would qualify under that standard. I'm not sure I understand what you mean by inconsistent aliasing. Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com Remember to vote! Consider donating to Postgres: http://www.postgresql.org/about/donate -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers