On Tue, Feb 21, 2017 at 7:28 AM, Amit Langote <langote_amit...@lab.ntt.co.jp> wrote: > Simon pointed out in a nearby thread [0] that the detail part of > partition-not-found error should show just the partition keys. I posted a > patch on that thread [1], but to avoid confusion being caused by multitude > of patches over there I'm re-posting it here.
Thanks. GetPartitionFailureData seems like a strange name for a datatype, particularly the "Get" part. How about PartitionRoutingFailureInfo? Or just two out parameters. Spelling: BuildSlotPartitinKeyDescription (in comment). ExecBuildSlotPartitionKeyDescription could have a comment saying that it's LIKE BuildIndexValueDescription() instead of copy-and-pasting the comments. And maybe BuildIndexValueDescription() could also get a comment saying that if we change anything there, we should check whether ExecBuildSlotPartitionKeyDescription() needs a similar change. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
