On 2/22/17 08:38, Pavan Deolasee wrote: > One reason why these macros are not always used is because they > typically do assert-validation to ensure ip_posid has a valid value. > There are a few places in code, especially in GIN and also when we are > dealing with user-supplied TIDs when we might get a TID with invalid > ip_posid. I've handled that by defining and using separate macros which > skip the validation. This doesn't seem any worse than what we are > already doing.
I wonder why we allow that. Shouldn't the tid type reject input that has ip_posid == 0? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
