On Mon, Mar 6, 2017 at 12:35 AM, Dilip Kumar <dilipbal...@gmail.com> wrote: > On Thu, Mar 2, 2017 at 6:52 PM, Robert Haas <robertmh...@gmail.com> wrote: >> 0002 wasn't quite careful enough about the placement of #ifdef >> USE_PREFETCH, but otherwise looks OK. Committed after changing that >> and getting rid of the local variable prefetch_iterator, which seemed >> to be adding rather than removing complexity after this refactoring. > > 0003 is rebased after this commit.
You've still got this: + if (DsaPointerIsValid(node->pstate->tbmiterator)) + tbm_free_shared_area(dsa, node->pstate->tbmiterator); + + if (DsaPointerIsValid(node->pstate->prefetch_iterator)) + dsa_free(dsa, node->pstate->prefetch_iterator); I'm trying to get to a point where both calls use tbm_free_shared_area() - i.e. no peeking behind the abstraction layer. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
