On Wed, Mar 8, 2017 at 9:59 AM, Tom Lane <[email protected]> wrote:
> Michael Paquier <[email protected]> writes:
> > here is a separate thread dedicated to the following extension for
> > CREATE/ALTER ROLE: PASSWORD ('value' USING 'method').
>
> The parentheses seem weird ... do we really need those?
>
+1
I had quick glance to patch and it looks great.
One quick comments:
+ | PASSWORD '(' Sconst USING Sconst ')'
+ {
+ $$ = makeDefElem("methodPassword",
+ (Node *)list_make2(makeString($3),
+ makeString($5)),
+ @1);
+ }
methodPassword looks bit weird, can we change it to passwordMethod
or pwdEncryptMethod ?
> regards, tom lane
>
>
> --
> Sent via pgsql-hackers mailing list ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>
--
Rushabh Lathia
