On 03/06/2017 10:16 AM, Kyotaro HORIGUCHI wrote:
At Fri, 3 Mar 2017 12:53:04 +0900, Michael Paquier <michael.paqu...@gmail.com> wrote 
in <cab7npqsqalozfng+5tf9s1tzs2pce-ghhnmg31qnsusv9vm...@mail.gmail.com>
On Thu, Mar 2, 2017 at 2:20 PM, Kyotaro HORIGUCHI
<horiguchi.kyot...@lab.ntt.co.jp> wrote:
5) Just remove plain map files and all related code. Addition to
   that, Makefile stores hash digest of authority files in
   Unicode/authoriy_hashes.txt or something that is managed by

That may be an idea to check for differences across upstream versions.
But that sounds like a separate discussion to me.

Fine with me either.

I did some more kibitzing here and there, and committed. Thanks everyone!

I agree the new maps should just replace the old maps altogether, so committed that way. I also moved the combined map files to the same .map files as the main radix trees. Seems more clear that way to me.

I changed the to/from_unicode properties back to a single direction property, with Perl constants BOTH, TO_UNICODE and FROM_UNICODE, per your alternative suggestion upthread. Seems more clear to me.

It would be nice to run the map_checker tool one more time, though, to verify that the mappings match those from PostgreSQL 9.6. Just to be sure, and after that the map checker can go to the dustbin.

- Heikki

Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:

Reply via email to