On 03/13/2017 08:53 PM, Tom Lane wrote:
Heikki Linnakangas <hlinn...@iki.fi> writes:
It would be nice to run the map_checker tool one more time, though, to
verify that the mappings match those from PostgreSQL 9.6.


Just to be sure, and after that the map checker can go to the dustbin.

Hm, maybe we should keep it around for the next time somebody has a bright
idea in this area?

The map checker compares old-style maps with the new radix maps. The next time 'round, we'll need something that compares the radix maps with the next great thing. Not sure how easy it would be to adapt.

Hmm. A somewhat different approach might be more suitable for testing across versions, though. We could modify the perl scripts slightly to print out SQL statements that exercise every mapping. For every supported conversion, the SQL script could:

1. create a database in the source encoding.
2. set client_encoding='<target encoding>'
3. SELECT a string that contains every character in the source encoding.

You could then run those SQL statements against old and new server version, and verify that you get the same results.

- Heikki

Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:

Reply via email to