On Thu, Mar 16, 2017 at 10:56 AM, Emre Hasegeli <e...@hasegeli.com> wrote: >> Hopefully, this time I got it correct. Since I am unable to reproduce >> the issue so I will again need your help in verifying the fix. > > It is not crashing with the new patch. Thank you.
Thanks for confirming. Some review comments on v2: + if (istate->pagetable) Please compare explicitly to InvalidDsaPointer. + if (iterator->ptbase) + ptbase = iterator->ptbase->ptentry; + if (iterator->ptpages) + idxpages = iterator->ptpages->index; + if (iterator->ptchunks) + idxchunks = iterator->ptchunks->index; Similarly. Dilip, please also provide a proposed commit message describing what this is fixing. Is it just the TBM_EMPTY case, or is there anything else? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
